Skip to content

Allow empty network.proxy settings #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2020
Merged

Allow empty network.proxy settings #830

merged 1 commit into from
Jul 14, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jul 14, 2020

This workaround must be here until viper can UnSet properties:

spf13/viper#519

@cmaglie
Allow empty network.proxy settings
876aa88 
This workaround must be here until viper can UnSet properties:
spf13/viper#519
@cmaglie cmaglie requested a review from rsora July 14, 2020 13:35
@cmaglie cmaglie self-assigned this Jul 14, 2020
@cmaglie cmaglie added this to the 0.12.0 milestone Jul 14, 2020
@cmaglie cmaglie merged commit 72c9655 into arduino:master Jul 14, 2020
@cmaglie cmaglie deleted the allow-empty-proxy-setting branch July 14, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rsora rsora rsora approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@cmaglie cmaglie

Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @rsora